Re: [bug-gawk] [PATCH] gawk 4.1.1 replace "/inet" with preprocessor macro

[Andrew J. Schorr]

Hi Arnold,

On Sun, Apr 20, 2014 at 12:15:54PM +0300, Aharon Robbins wrote:
> This patch looks pretty good. Please change "nul-terminated" in the
> comment to either "NUL-terminated" or "zero-terminated" and then I
> think it's good to go.

I changed it to say "NUL-terminated".

> After the explanation, I'm fine with using offsets; you may wish to add
> a comment somewhere that using offsets avoids problems with "char *"
> vs. "const char *" mismatches and compiler warnings.

I added a comment in the definition of the struct.

> Please commit to gawk-4.1-stable and then merge to master. You should
> do a git pull before starting. :-)

I have done so.

> Much thanks for handling this.

You're welcome.

-Andy