bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lib/xtime.h is included twice


From: Georg Schwarz
Subject: Re: lib/xtime.h is included twice
Date: Thu, 3 Mar 2005 15:21:22 +0100 (CET)

I cannot judge this.
I was just following the example given in
http://cvsweb.NetBSD.org/bsdweb.cgi/src/share/misc/style?rev=HEAD&content-type=text/x-cvsweb-markup

If you think different naming conventions are more appropriate, I don't mind.


> address@hidden wrote:
> > Dear cvs developers,
> > 
> > for cvs 1.11.19 and earlier, lib/xtime.h is included twice, 
> > which breaks
> > compiling on IRIX 5.3.
> > The following patch prevents this:
> > 
> > --- lib/xtime.h.orig    2005-03-01 15:53:11.000000000 +0100
> > +++ lib/xtime.h 2005-03-01 15:54:20.000000000 +0100
> > @@ -12,6 +12,9 @@
> >   * functions
> >   */
> >  
> > +#ifndef _XTIME_H_
> > +#define _XTIME_H_
> ISO C Standard reserves names beginning with underscore and an uppercase
> character, or beginning with two underscores. I recommend changing this to
> something like:
> 
> #ifndef XTIME_HEADER_INCLUDEd
> #define XTIME_HEADER_INCLUDEd
> 
> (note: the lower-case d at the end is deliberate - it's my technique to
> reduce the chances of a name collision.)
> 
> -- 
> Jim Hyslop
> Senior Software Designer
> Leitch Technology International Inc. ( http://www.leitch.com )
> Columnist, C/C++ Users Journal ( http://www.cuj.com/experts )
> 
> 
> 
> 
> 

-- 
Georg Schwarz    http://home.pages.de/~schwarz/
 address@hidden  +49 178 8545053





reply via email to

[Prev in Thread] Current Thread [Next in Thread]