bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: lib/xtime.h is included twice


From: Jim.Hyslop
Subject: RE: lib/xtime.h is included twice
Date: Thu, 3 Mar 2005 11:25:54 -0500

Derek Price wrote:
> Jim.Hyslop wrote:
> 
> | address@hidden wrote:
> |
> |> Dear cvs developers,
> |>
> |> for cvs 1.11.19 and earlier, lib/xtime.h is included twice, which
> |> breaks compiling on IRIX 5.3. The following patch prevents this:
> |>
> |> --- lib/xtime.h.orig    2005-03-01 15:53:11.000000000 +0100 +++
> |> lib/xtime.h 2005-03-01 15:54:20.000000000 +0100 @@ -12,6 +12,9 @@
> |>  * functions */
> |>
> |> +#ifndef _XTIME_H_ +#define _XTIME_H_
> |
> | ISO C Standard reserves names beginning with underscore and an
> | uppercase character, or beginning with two underscores. I recommend
> | changing this to something like:
> |
> | #ifndef XTIME_HEADER_INCLUDEd #define XTIME_HEADER_INCLUDEd
> |
> | (note: the lower-case d at the end is deliberate - it's my
> | technique to reduce the chances of a name collision.)
> 
> 
> I'm ok with this if you'd like to apply it, Jim.
Will do.

Georg, have you tested your patch on any other platforms? It should be
harmless, but I've been bitten by enough harmless-looking patches to be wary
:-)

-- 
Jim Hyslop
Senior Software Designer
Leitch Technology International Inc. ( http://www.leitch.com )
Columnist, C/C++ Users Journal ( http://www.cuj.com/experts )





reply via email to

[Prev in Thread] Current Thread [Next in Thread]