[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

possible bug with ignoring directories in module file

From: James E Wilson
Subject: possible bug with ignoring directories in module file
Date: Fri, 20 Aug 2004 20:42:24 -0700

The GCC CVS repository has directories gcc/f, gcc/fixinc, gcc/fortran. 
We have a module defined in the modules file which has
When we check out this module, not only is the gcc/f directory removed,
but also the gcc/fixinc and gcc/fortran directories.

I see no explanation of this feature in the manual.  It appears to be a

Inspecting the source code, I believe the problem is in ignore_directory
in ignore.c.  There is a line which calls strncmp passing in strlen() as
the number of characters to compare.  However, since strlen does not
include the terminating null character, this means !gcc/f will match

I possible solution is attached.  I have not tested this patch, as I
don't have a cvs server/repository I can use for testing patches.  The
patch is relative to cvs-1.12.9.

Alternatively this could be fixed by documenting this behaviour as
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

Attachment: patch.ignore
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]