bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for timezone handling in cvs log


From: Bart Robinson
Subject: Re: Patch for timezone handling in cvs log
Date: Wed, 5 May 2004 15:00:04 -0700 (PDT)

On 2004-5-5 Derek Robert Price <address@hidden> wrote:
 > Bart Robinson wrote:
 > 
 > >On 2004-5-1 Derek Robert Price <address@hidden> wrote:
 > > > Bart Robinson wrote:
 > > >
 > > > >Here is a simpler patch incorporating Derek's ideas with getting
 > > > >rid of the -z and omitting the gratuitous MT stuff in log.c.
 > 
 > 
 > Okay, Bart, almost ready to commit.  I'll probably commit your patch
 > almost as is to stable, but I have a question before I decide to
 > commit it to feature -
 > 
 > I noticed in your comment that you say you copied tm_diff() directly
 > from the glibc strftime.c.  Why did you decide against actually using
 > strftime()?
 > 
 > Derek

I didn't consider using strftime.  The comment above that
routine is verbatim from ../lib/getdate.y.  I wanted to use the
one from getdate but it is static.

Looking at strftime, it doesn't look like it would have been
useful for what I was trying to do (diff two struct tm's).

Thanks
-- bart




reply via email to

[Prev in Thread] Current Thread [Next in Thread]