Re: Patch for timezone handling in cvs log

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bart Robinson wrote:

>Here is a simpler patch incorporating Derek's ideas with getting
>rid of the -z and omitting the gratuitous MT stuff in log.c.
>
>OVERVIEW
>--------
>
>These changes make log/rlog output dates in local time by
>default.  If the user wants GMT or any other timezone supported
>by their system, they can modify their TZ env var accordingly.


This is almost perfect short of a few minor issues:

   1. tm_diff should be static and not have a prototype in cvs.h until
      it is actually being used elsewhere.
   2. both tm_diff & format_date_alloc should probably be in subr.c
      rather than main.
   3. the output date format should use dashes instead of slashes for
      compliance with the ISO 8601 specification.


Most of these are minor enough that I would have fixed them myself as
I checked it in, but I need ChangeLogs & doc from you too.

>I will gladly update docs, ChangeLogs, etc if this approved.
>
>ISSUES
>------
>
>1. I didn't change "cvs history" to handle dates in this
>   manner.  It has a -z argument that can achieve similar
>   results, but should eventually be updated.  Some other
>   commands could benefit from time conversion, like stat and
>   diff.


I think I might deprecate -z passed to history, at least on feature.
Is anyone using it for anything other than printing times in the local
timezone?  I'll also consolidate the history's date formatting
functions with Bart's.  Probably I'll have format_date_alloc accept an
optional TZ offset argument and only compute the offset when one isn't
received until the feature goes away.

As for stat & diff, I agree, but now the support functions will be in
place to make implenting the features easy.

Thanks for the patch!

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAk74mLD1OTBfyMaQRAht/AJ9RTL9+mMkDWy2TrufK7dTDGScInwCfSoks
9kqq28TJsB3tAmkRe+0Gxx4=
=w2Uy
-----END PGP SIGNATURE-----