[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[avrdude-dev] [patch #7729] Updated support for FTDI-232H
|
From: |
Hannes Weisbach |
|
Subject: |
[avrdude-dev] [patch #7729] Updated support for FTDI-232H |
|
Date: |
Fri, 24 Feb 2012 20:40:32 +0000 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.46 Safari/535.11 |
Follow-up Comment #1, patch #7729 (project avrdude):
Hi,
I had a quick look and it looks fine to me. I have just one question. You
changed:
if (pgm->pinno[PIN_AVR_RESET] < 4 || pgm->pinno[PIN_AVR_RESET] == 0) {
to:
if (pgm->pinno[PIN_AVR_RESET] < 5 || pgm->pinno[PIN_AVR_RESET] == 0) {
and I don't understand why. Using pin 4 (TMS/CS) as reset-pin is a valid
choice and indeed the default. Four lines below pgm->pinno[PIN_AVR_RESET]
actually gets set to 4.
Cheers,
Hannes
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?7729>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.nongnu.org/