[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New test: distributed broken symlinks cause failure.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] New test: distributed broken symlinks cause failure. |
Date: |
Sun, 20 Jun 2010 20:49:37 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:53:17PM CEST:
> I ping this again, since I'm pretty sure it has fallen off your radar.
>
> I say so because, since the last ping, you have applied (or at least
> commented) much bigger and potentially more invasive patches of mine,
> but not this one.
>
> BTW, In the meantime, I've also made some small improvements to the
> test script, which are IMO quite valuable.
Thanks. There is a typo diagnositic in the comments.
The test doesn't look safe for MinGW. Its 'ln -s' is emulated by 'cp
-p' which, from looking at the test, will cause a failure not a skip.
I'm wondering whether we should be throwing short file name support out
of the window completely with Automake; this is an issue for this test
because distlinksbrk.test shares >= 8 characters before the dot with
distlinks.test; info Autoconf 'File System Conventions' has details.
So far we don't have many files which don't adhere to this. (It's not
necessary to limit names to 8 characters, but for the one registry
setting they should be unique when taking only the first 8, plus the
first three of the extension.) Comments?
Thanks,
Ralf
> From bf254929cc79c1ae4d7572e64e5ac38da74255e8 Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Sat, 15 May 2010 15:40:16 +0200
> Subject: [PATCH] New test: distributed broken symlinks cause failure.
>
> * tests/distlinksbrk.test: New test.
> * tests/Makefile.am (TESTS): Updated accordingly.