[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Modernize, improve and extend tests `suffix*.test'.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Modernize, improve and extend tests `suffix*.test'. |
Date: |
Sun, 20 Jun 2010 20:30:37 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Stefano Lattarini wrote on Sat, Jun 19, 2010 at 10:47:10PM CEST:
> Yet another testsuite-tweaking patch (the last one for today).
> Modernize, improve and extend tests `suffix*.test'.
>
> * tests/suffix3.test: Enable `errexit' shell flag, and related
> changes.
> * tests/suffix4.test: Likewise.
> * tests/suffix6.test: Likewise, and do not create a useless dummy
> source file.
> * tests/suffix7.test: Likewise.
> * tests/suffix5.test: Enable `errexit' shell flag, and related
> changes. Make grepping of Makefile.in slighty stricter.
> * tests/suffix.test: Enable `errexit' shell flag, and related
> changes. Also, do not redirect grep output to /dev/null, as this
> might unmotivatedly hide useful information.
> * tests/suffix2.test: Move setting of `errexit' shell flag earlier
> in the script (just after inclusion of ./defs). Use a more
> idiomatic way to count text occurrences in Makefile.in with
> grep. Do not create useless dummy source files.
> * tests/suffix10.test: Ensure verbose printing of captured make
> stdout. Minor cosmetic changes.
> * tests/suffix8.test: Likewise. Also, drop useless call to the
> env(1) utility, and make grepping of make output stricter by using
> $FGREP rather than plain grep.
> * tests/suffix11.test: Likewise.
> * tests/suffix12.test: Likewise.
> * tests/suffix9.test: Prefet cat + here-doc over echo to append to
> the `configure.in' stub. Cosmetic changes.
> * tests/suffix13.test: Cosmetic spacing change.
Thanks! For maint, with this squashed in to cater to variations between
branch-1.11 and master.
Cheers,
Ralf
--- a/tests/suffix11.test
+++ b/tests/suffix11.test
@@ -1,5 +1,5 @@
#! /bin/sh
-# Copyright (C) 2002, 2003 Free Software Foundation, Inc.
+# Copyright (C) 2002, 2003, 2010 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -49,7 +49,7 @@ $AUTOCONF
# What we do is not portable. Automake should warn.
AUTOMAKE_fails -a
-grep 'inference rules can have only one target before the colon' stderr
+grep '[iI]nference rules can have only one target before the colon' stderr
# But this should work anyway.
$AUTOMAKE -a -Wno-portability