Re: no-dist-gzip

[Akim Demaille]

>>> "Akim" == Akim Demaille <address@hidden> writes:

 Akim> I did that, but I did not have in mind you wanted that
 Akim> guy to be public.  I don't see the point actually.  What
 Akim> will you do if the user defines it?

 > My idea was that DIST_ARCHIVES would help people who write
 > custom release rules around `make distcheck' or `make dist'.
 > For instance `make upload'.

OK.


 > Now that you mention it, I think that if your extraction
 > switch/case was moved into a separate target (undist?), one could
 > build some exotic archive by just redefining dist, undist, and
 > DIST_ARCHIVES.

That would be fairly inefficient.  We might want to look for something
like

dist-all: distdir distarchive distdir-rm

(no command) and let the user add things to distarchives.


 > Preferably with a test case to prevent errors similar to those
 > you recently reported.

Sorry, but other stuff stack...

 >> -     && $(MAKE) $(AM_MAKEFLAGS) dist-gzip \
 >> -## Make sure to remove the dist file we created in the test build
 >> +     && $(MAKE) $(AM_MAKEFLAGS) distdir \
 >> +## Make sure to remove the dist dir we created in the test build
 >> ## directory.
 >> -     && rm -f $(distdir).tar.gz \
 >> +     && rm -rf $(distdir) \

 > How about
 >   $(MAKE) $(AM_MAKEFLAGS) dist
 >   rm -f $(am__dist_archives)
 > ?  This looks closer to what users do.

I was trying to save the generation of several tarballs for free.  But
OK.


 >> -   @echo "$(distdir).tar.gz is ready for distribution" | \
 >> -     sed 'h;s/./=/g;p;x;p;x'
 >> +   $(MAKE) $(AM_MAKEFLAGS) dist
 >> +   @(echo "$(distdir) archives ready for distribution: "; \
 >> +     for i in $(am_dist_archives); do echo $$i; done) | \
 >> +     sed -e '1{h;s/./=/g;p;x}' -e '$${p;x}'

 > The call to `make dist' seems to be a leftover from the previous patch.

Removed.  Here it is.

diffs.patch
Description: Text Data