[Alsa-xmms-user] [PATCH] Buffer time fix

[Ville Syrjälä]

Hi,

I got tired of OSS emulation and tried your plugin. Nice work.

There is however a bug in the buffer size setup. The buffer time is
supposed to be in ms but the default value is 500000 that would be 500
seconds :) I think you meant it to be 500 ms. The multiplication from ms
to us was also broken.

There is no devel list so I pasted the patch below and also sent it to the
patch manager at the project page. 

diff -urN alsa-xmms-0.9-orig/src/audio.c alsa-xmms-0.9/src/audio.c
--- alsa-xmms-0.9-orig/src/audio.c      Fri Apr  5 17:16:06 2002
+++ alsa-xmms-0.9/src/audio.c   Fri Apr 26 06:04:25 2002
@@ -548,7 +548,7 @@
        }
   
 
-       alsa_buffer_time = snd_pcm_hw_params_set_buffer_time_near(alsa_pcm, 
hwparams, alsa_cfg.buffer_time * 100, 0);
+       alsa_buffer_time = snd_pcm_hw_params_set_buffer_time_near(alsa_pcm, 
hwparams, alsa_cfg.buffer_time * 1000, 0);
        if (alsa_buffer_time < 0) error("Buffer time < 0");
   
        if (snd_pcm_hw_params_set_period_time_near(alsa_pcm, hwparams,
alsa_buffer_time / 4, 0) < 0) error("Period time < 0");
diff -urN alsa-xmms-0.9-orig/src/init.c alsa-xmms-0.9/src/init.c
--- alsa-xmms-0.9-orig/src/init.c       Thu Mar 21 18:01:25 2002
+++ alsa-xmms-0.9/src/init.c    Fri Apr 26 06:04:32 2002
@@ -36,7 +36,7 @@
   alsa_cfg.audio_device = 0;
   alsa_cfg.use_user_device = 0;
   alsa_cfg.user_device = NULL;
-  alsa_cfg.buffer_time = 500000;
+  alsa_cfg.buffer_time = 500;
   alsa_cfg.use_master = 0;
   alsa_cfg.surround = 0;
   alsa_cfg.debug = 0;

-- 
Ville Syrjälä
address@hidden
http://www.sci.fi/~syrjala/