Re: bnv_have_qt: QT_CXXFLAGS should contain -DQT_THREAD_SUPPORT if needed

[Bastiaan Veelo]

Peter Simons wrote:

> Martin Godisch writes:
>
> > Qt programs should be compiled with -DQT_THREAD_SUPPORT
> > if the Qt library used is multi threaded, according to
> > /usr/share/qt3/doc/html/threads.html in qt3-doc
> > (3.3.3-4.1). I think bnv_have_qt.m4 should add
> > -DQT_THREAD_SUPPORT to QT_CXXFLAGS if needed.
>
> > [...]
>
> > --- bnv_have_qt.m4.orig    2004-11-26 23:40:31.000000000 +0000
> > +++ bnv_have_qt.m4 2004-11-26 23:38:40.000000000 +0000
> > @@ -102,6 +102,9 @@
> >    fi   # $have_qt reflects the system status
> >    if test x"$have_qt" = xyes; then
> >      QT_CXXFLAGS="-I$bnv_qt_include_dir"
> > +    if test $bnv_qt_lib = "qt-mt"; then
> > +        QT_CXXFLAGS="$QT_CXXFLAGS -DQT_THREAD_SUPPORT"
> > +    fi
> >      QT_DIR="$bnv_qt_dir"
> >      QT_LIBS="$bnv_qt_LIBS"
> >      # If bnv_qt_dir is defined, utilities are expected to be in the
>
> I can apply that patch alright. Bastiaan, is this okay with
> you?
>
> Peter
>  
This and other patches got stalled because I am trying to deal with the 
fact that my macro is in XML. My biggest concern is still that Guido's 
archive is not in sync with yours with respect to my macro. I am 
pondering the idea of using

 <m4source href="bnv_have_qt.m4">

maybe that helps. I dont think that Guido is scanning the XML tree though. Could we have 

 <m4source href="../legacy/bnv_have_qt.m4">

instead?

In the mean time, you can apply the patch. If you do, please mention Martin's 
name just below the THANKS line in the m4 source.

Bastiaan.