Re: wget2 | Draft: CIDR support added for No Proxy. Testing Code Added (!521)

[Harshmohan Kulkarni (@harshmohan07)]

Harshmohan Kulkarni commented:


The major issue in the current pipeline failure is related to the shifting and 
mask creation in the process.
A test case fails in one of the pipelines, which has '32' as the `prefix_len`. 
In the other one, we get this error `implicit conversion from type 'unsigned 
long' of value 18446744073708503040 (64-bit, unsigned) to type 'uint32_t'`. I 
suggest making a map of prefix_len and the actual masks, freeing the 
implementation from any shifting-related issues. It will be more efficient than 
doing shifting and inversion for every comparison. Please have a thought on 
this.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/521#note_1346304912
You're receiving this email because of your account on gitlab.com.