wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Draft: CIDR support added for No Proxy. Testing Code Added (


From: @rockdaboot
Subject: Re: wget2 | Draft: CIDR support added for No Proxy. Testing Code Added (!521)
Date: Sun, 09 Apr 2023 17:39:15 +0000



Tim Rühsen started a new discussion on unit-tests/test.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/521#note_1346182571

> +             { "", "142.250.180.101", NULL, 0},
> +             { "142.251.33.101,10.250.192.78/12", "142.251.33.101", NULL, 1},
> +             { "10.250.192.78/12, 142.251.33.101", "142.251.33.101", NULL, 
> 0},
> +     };
> +
> +     for (unsigned it = 0; it < countof(test_data); it++) {
> +             const struct test_data *t = &test_data[it];
> +             wget_http_set_no_proxy(t->no_proxy, t->encoding);
> +             wget_vector* no_proxies = wget_http_get_no_proxy();
> +             int n = wget_http_match_no_proxy(no_proxies, t->hostip);
> +
> +             if (n == t->result)
> +             {
> +                     ok++;
> +             }
> +             else {

Could you please apply the "surrounding" code formatting, e.g.
```suggestion:-4+0
                if (n == t->result) {
                        ok++;
                } else {
```
Please also check the rest of your code.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/521#note_1346182571
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]