Re: [Tinycc-devel] Reformatting Tinycc source code

[Tyge Løvset]

No problem, I should have read the CodingStyle file. @grischka, you are right, tabs are consistently 8 indents.

It is also true that it is not blame-friendly, apart from blaming those who aren't following the style guides, of course ;)

|Doesn't really look much different to me except that it seems to create

 |10233 changes which isn't really the git-blame friendly way of making
 |not much difference ;)

I guess I just regard this a little more important than you guys, I know some projects are even forcing all code through a formatter,

which is too much imo, so it comes down to preference in the end.

Cheers,

Tyge

On Wed, 2 Dec 2020 at 18:16, Steffen Nurpmeso <steffen@sdaoden.eu> wrote:

grischka wrote in
 <5FC78136.10707@gmx.de" target="_blank">5FC78136.10707@gmx.de>:
 |Tyge Løvset wrote:
 |> I have slowly started to look into the core code of tinycc, but can't
 |> help being annoyed by the inconsistent formatting of the code, in
 |> particular the mixing of tabs and spaces. (sometimes tabs means 4
 |> indents, sometimes 8).
 |
 |Not anywhere in tcc that I know are tabs equal to anything else
 |than 8 spaces, visually.
 |
 |IOW if you would replace all tabs by 8 spaces it would look just
 |the same, annoying or not annoying.
 |
 |> Here is a suggestion for an Artistic Style -
 |> ...
 |> Would anyone care to review the changes it creates, before a possible
 |> commit? So far it looks good, and I haven't spotted any errors created
 |> by the reformatting so far.
 |
 |Doesn't really look much different to me except that it seems to create
 |10233 changes which isn't really the git-blame friendly way of making
 |not much difference ;)

-w to ignore whitespace changes.

--steffen
|
|Der Kragenbaer,                The moon bear,
|der holt sich munter           he cheerfully and one by one
|einen nach dem anderen runter  wa.ks himself off
|(By Robert Gernhardt)

_______________________________________________
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel