Re: makeinfo and end-of-line format

[Eli Zaretskii]

> Date: Wed, 17 Jun 2015 00:10:16 +0100
> From: Gavin Smith <address@hidden>
> Cc: Patrice Dumas <address@hidden>, address@hidden
> 
> On 16 June 2015 at 16:04, Eli Zaretskii <address@hidden> wrote:
> >> Date: Mon, 15 Jun 2015 18:09:02 +0100
> >> From: Gavin Smith <address@hidden>
> >>
> >> I've attached the first change I made, which collects the calls to
> >> open_out in a single function. It should be easy to add the argument
> >> to open_out here, in _open_info_file in my patch.
> >
> > Just so this doesn't fall through the cracks: am I expected to do
> > something with this patch?
> 
> I've committed a change to only do the binmode calls for Info output.
> Please have a try and see if the output looks correct.

I tried it, and the Info files came out with CRLF EOLs.  Took me a
while, but I found a copy-paste error, see below.  After fixing that,
the Info output has Unix EOLs, while HTML output has DOS CRLF EOLs.

I also bumped into a Gnulib-related compilation problem, which I will
report separately.

Thanks.

--- tp/Texinfo/Common.pm        (revision 6341)
+++ tp/Texinfo/Common.pm        (working copy)
@@ -1067,7 +1067,7 @@
   # We run binmode to turn off outputting LF as CR LF under MS-Windows,
   # so that Info tag tables will have correct offsets.  This must be done
   # before setting the encoding filters with binmode.
-  binmode(STDOUT) if $use_binmode;
+  binmode($filehandle) if $use_binmode;
   if ($encoding) {
     if ($encoding eq 'utf8' or $encoding eq 'utf-8-strict') {
       binmode($filehandle, ':utf8');