Re: sed-4.8.39-23ea on macOS

[Jim Meyering]

On Sun, Oct 16, 2022 at 5:58 PM Bruno Haible <bruno@clisp.org> wrote:
> On macOS 10.13, I am seeing three test failures:
>
> FAIL: testsuite/bug32082
> ========================
>
> valgrind report for 'posix' test:
> ==================================
> --85029-- run: /usr/bin/dsymutil 
> "/Users/haible/devel/sed-4.8.39-23ea/build-64/./sed/sed"
> --85029-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
> --85029-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2 
> times)
> --85029-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4 
> times)
> --85029-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8 
> times)
> ==85029== Invalid read of size 16
> ==85029==    at 0x100EE6A05: _platform_memchr$VARIANT$Base (in 
> /usr/lib/system/libsystem_platform.dylib)
> ==85029==    by 0x100B7B0BD: getdelim (in /usr/lib/system/libsystem_c.dylib)
> ==85029==    by 0x10000B0BE: ck_getdelim (utils.c:254)
> ==85029==    by 0x1000090A9: read_file_line (execute.c:388)
> ==85029==    by 0x100008A12: read_pattern_space (execute.c:718)
> ==85029==    by 0x1000066DA: process_files (execute.c:1682)
> ==85029==    by 0x10000A5D9: main (sed.c:378)
> ==85029==  Address 0x1019bf1a0 is 16 bytes before a block of size 65,536 
> alloc'd
> ==85029==    at 0x1000E7545: malloc (vg_replace_malloc.c:302)
> ==85029==    by 0x100B7B500: __smakebuf (in /usr/lib/system/libsystem_c.dylib)
> ==85029==    by 0x100B7EC75: __srefill0 (in /usr/lib/system/libsystem_c.dylib)
> ==85029==    by 0x100B7ED65: __srefill (in /usr/lib/system/libsystem_c.dylib)
> ==85029==    by 0x100B7B136: getdelim (in /usr/lib/system/libsystem_c.dylib)
> ==85029==    by 0x10000B0BE: ck_getdelim (utils.c:254)
> ==85029==    by 0x1000090A9: read_file_line (execute.c:388)
> ==85029==    by 0x100008A12: read_pattern_space (execute.c:718)
> ==85029==    by 0x1000066DA: process_files (execute.c:1682)
> ==85029==    by 0x10000A5D9: main (sed.c:378)
> ==85029==
> ==================================
> valgrind report for 'no-posix' test:
> ====================================
> --85039-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
> --85039-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2 
> times)
> --85039-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4 
> times)
> --85039-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8 
> times)
> ====================================
> FAIL testsuite/bug32082.sh (exit status: 1)
>
> FAIL: testsuite/bug32271-2
> ==========================
>
> grep: err-no-posix: No such file or directory
> diff -u /dev/null err
> --- /dev/null   1970-01-01
> +++ err 1970-01-01
> +--85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
> +--85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2 
> times)
> +--85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4 
> times)
> +--85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8 
> times)
> valgrind report:
> ==================================
> --85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
> --85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2 
> times)
> --85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4 
> times)
> --85182-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8 
> times)
> ==================================
> FAIL testsuite/bug32271-2.sh (exit status: 1)
>
> FAIL: testsuite/newline-dfa-bug
> ===============================
>
> diff -u /dev/null err
> --- /dev/null   1970-01-01
> +++ err 1970-01-01
> +--87473-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option
> +--87473-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 2 
> times)
> +--87473-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 4 
> times)
> +--87473-- UNKNOWN mach_msg unhandled MACH_SEND_TRAILER option (repeated 8 
> times)
> FAIL testsuite/newline-dfa-bug.sh (exit status: 1)
>
>
> The first failure goes away with the getdelim workaround that I just
> committed to gnulib. The two other failures remain.

Nice catch and fix.
For now, I am not inclined to work around the "UNKNOWN"-related failures.
I suspect very few people install their own valgrind on such hosts.
Also, I'm hoping that's been addressed in a more recent version.
Latest seems to be 3.19.0.

> The valgrind version that I have on this machine is
> $ valgrind --version
> valgrind-3.14.0.GIT