[Savannah-hackers-public] submit changes and return to this item

[Karl Berry]

For the record ... here is the patch that I just referred to in
https://savannah.gnu.org/task/?13522#comment13.  I happened to get the
same "nogroup" message on puszcza as the OP did here, and Sergey fixed
it in short order.  (Thanks Sergey.)  I just committed the patch to
administration/savane.git; it applied fine (only uselessly annoying
whitespace differences).

karl


From: Sergey Poznyakoff <address@hidden>
Date: Sat, 4 Apr 2015 09:13:20 +0300
Subject: [PATCH] Fix 'submit and return to this item'.

Clicking on "submit changes and return to this item" button would
return to the item, but the item_id in the URL would be lost. This
caused all relative links on the page to become invalid.

Reported by Karl on 2015-04-02 <address@hidden>.

* frontend/php/include/trackers_run/index.php: Use redirect instead of
file inclusion when 'submit and return to this item' is requested.
---
 frontend/php/include/trackers_run/index.php | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/frontend/php/include/trackers_run/index.php 
b/frontend/php/include/trackers_run/index.php
index dfa7aad..abc3c36 100644
--- a/frontend/php/include/trackers_run/index.php
+++ b/frontend/php/include/trackers_run/index.php
@@ -505,9 +505,7 @@ switch ($func)
                                     $reassign_change_project,
                                     $reassign_change_artifact);
        }
-

-
      # show browse item page, unless the user want to get back
      # to the
      # same report, to make something else
@@ -517,13 +515,21 @@ switch ($func)
        }
      else
        {
-        $_POST = $_FILES = array();
-        $form_id = $depends_search = $reassign_change_project_search = $add_cc
-          = $input_file = $changed = $vfl = $details = $comment = null;
-        $nocache = 1;
-        include '../include/trackers_run/mod.php';
+        if (preg_match("/:\/\/($sys_default_domain)|($sys_https_host)/",
+                       $_SERVER[HTTP_REFERER]))
+           {
+            header('Location: ' . $_SERVER[HTTP_REFERER]);
+          }
+         else
+           {
+            $_POST = $_FILES = array();
+            $form_id = $depends_search =
+             $reassign_change_project_search = $add_cc =
+             $input_file = $changed = $vfl = $details = $comment = null;
+            $nocache = 1;
+            include '../include/trackers_run/mod.php';
+           }
        }
-
      break;
    }

--
1.8.3.1