Re: [Savannah-hackers-public] mock review for the project scruf

[Michael J. Flickinger]

On 10/27/12 3:55 AM, Rudra Banerjee wrote:
> Hello friends,
> below is a mock review of the project scurf.
> Please let me know if this is good.
> The project link is https://savannah.gnu.org/task/?12298
>
> ========================================================================
> Hi,
> I'm evaluating the project you submitted for approval in Savannah. While
> doing so I have noticed a few problems which are described below.
>
> 1) Your file parser/DocumentDate.java, styling/style.css and todo are
> missing copyright headers and license notices.

I don't think we really care too much about meta-project files, such as 
BUGS, TODO, THANKS, etc.  These files are not documentation nor are the 
part of the program.  I've personally never nagged for licensing headers 
on such files.

It also appears that plenty of GNU projects lack licensing notices on 
such files.

You are correct thought, parsers/DocumentDate.java is slightly past the 
threshold of trivial code, so it probably should have a licensing header.

styling/style.css is attributed to the public domain with the following 
header:

/*
  Author:  rsiddharth
  Contact: <address@hidden>
  License: Public Domain 
<http://creativecommons.org/publicdomain/zero/1.0/>
*/

> Please submit a tarball on the bottom of this page with the updated
> files.

Since this project has only one minor problem, I'd probably recommend 
passing, suggesting that a licensing notice be added to the 
parsers/DocumentDate.java.


> Best regards.
> =====================================================================
>
> I would like to become a project reviewer. my savannah id is roddur.
> Regards,

I added you to the administration project, so you'll be able to 
correspond with the ticket submitter here:

https://savannah.gnu.org/task/?12298

I'd strongly advise using the review-correspondence scripts for 
generating replies to project submitters:

http://git.savannah.gnu.org/cgit/administration.git/plain/approvals/savannah.el 
(for emails)
http://git.savannah.gnu.org/cgit/administration.git/plain/approvals/savannah.vim 
(for vim)

Feel free to pick and choose reviews for the time being.  I'll be 
watching your interactions and will provide feedback to you.  If you are 
unsure of anything, when it comes to a review, please email this list 
with any question you may have.  Additionally, we have an IRC channel on 
irc.freenode.net (channel #savannah) where you may ask questions.

For now, just write to the project submitter that their review has 
either been accepted or declined.  I'll manually approve the projects 
after you send the submitter their approval notice.  After we do a few 
of these and you feel comfortable, you'll have access to either accept 
and create the projects yourself.

Thanks.