Re: [RP] Bug: definekey top with nonexistent key

[Trent Buck]

Up spake Magnus Henoch:
> I'm using the same ratpoisonrc on several systems, among them Sun
> computers where the Pause key is known to X as F21.  Thus, I use the
> following:
> 
> definekey top F21 echo foo
> 
> This works with the Suns.  But when I use that file on systems without
> any F21 keys (all of them running XFree86), ratpoison doesn't let
> keyboard events through to clients.  xev shows no output when I hammer
> on the keyboard.  ratpoison itself is still responsive.
> 
> Is the answer simply "don't do that", or can this be fixed?

The XKeysymToKeycode(3X) manpage observes that it returns 0 if the
keysym can't be resolved.  There should therefore be a check in
input.c:grab_key...

   keysym_to_keycode_mod (keysym, &keycode, &mod);
+  unless (*keycode)
+    whinge();
   PRINT_DEBUG (("keycode_mod: %ld %d %d\n", keysym, keycode, mod));


...but ICBW.

-- 
-trent
Like the man said: "Nothing good ever goes in /opt." -- Tim Foreman