Re: [PATCH] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15

[Philippe Mathieu-Daudé]

On 11/11/22 08:43, Thomas Huth wrote:
> On 10/11/2022 21.00, Philippe Mathieu-Daudé wrote:
> > On 10/11/22 14:11, Thomas Huth wrote:
> > > Clang 15 from Fedora 37 complains:
> > >
> > >   ../libdecnumber/dpd/decimal64.c:620:8: error: variable 'n' set but
> > >   not used [-Werror,-Wunused-but-set-variable]
> > >     Int  n;                     /* output bunch counter */
> > >          ^
> > >   1 error generated.
> > >
> > > Remove the unused variable to silence the compiler warning.
> > >
> > > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > > ---
> > >   libdecnumber/dpd/decimal64.c | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)

> > Or we could we backport the upstream fix :)
> >
> > https://gcc.gnu.org/git/?p=gcc.git;a=blobdiff;f=libdecnumber/dpd/decimal64.c;h=f72c5730ac3b473e2c334f604e7e52da9711fa72;hp=269eaecade5115a62e979897742cd5decec0681e;hb=8a79685989bff33f479d0ac2df0e18d55d3ba78b;hpb=e1d1842b5432472330384d1523bb3c3132c4fea0 
>
> I did not look on that code on purpose - it's licensed under the GPLv3, 
> so we should not mix that back into our GPLv2 version.

Sigh, right. So:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>