Re: [PATCH] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15

[Cédric Le Goater]

On 11/10/22 14:11, Thomas Huth wrote:
> Clang 15 from Fedora 37 complains:
>
>   ../libdecnumber/dpd/decimal64.c:620:8: error: variable 'n' set but
>   not used [-Werror,-Wunused-but-set-variable]
>     Int  n;                     /* output bunch counter */
>          ^
>   1 error generated.
>
> Remove the unused variable to silence the compiler warning.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   libdecnumber/dpd/decimal64.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libdecnumber/dpd/decimal64.c b/libdecnumber/dpd/decimal64.c
> index 4816176410..290dbe8177 100644
> --- a/libdecnumber/dpd/decimal64.c
> +++ b/libdecnumber/dpd/decimal64.c
> @@ -617,7 +617,6 @@ static const uInt multies[]={131073, 26215, 5243, 1049, 
> 210};
>   #endif
>   void decDigitsToDPD(const decNumber *dn, uInt *targ, Int shift) {
>     Int  cut;                 /* work */
> -  Int  n;                    /* output bunch counter */
>     Int  digits=dn->digits;     /* digit countdown */
>     uInt dpd;                 /* densely packed decimal value */
>     uInt bin;                 /* binary value 0-999 */
> @@ -676,7 +675,7 @@ void decDigitsToDPD(const decNumber *dn, uInt *targ, Int 
> shift) {
>       bin=0;                       /* [keep compiler quiet] */
>     #endif
>   
> -  for(n=0; digits>0; n++) {	   /* each output bunch */
> +  while (digits > 0) {             /* each output bunch */
>       #if DECDPUN==3               /* fast path, 3-at-a-time */
>         bin=*inu;                          /* 3 digits ready for convert */
>         digits-=3;                 /* [may go negative] */