[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the
|
From: |
John Snow |
|
Subject: |
Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type |
|
Date: |
Mon, 11 Jul 2022 16:30:11 -0400 |
On Mon, Jul 11, 2022 at 5:57 AM Thomas Huth <thuth@redhat.com> wrote:
>
> 'returns-whitelist' has been renamed to 'command-returns-exceptions' in
> commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions").
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> python/qemu/qmp/legacy.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
> index 03b5574618..1951754455 100644
> --- a/python/qemu/qmp/legacy.py
> +++ b/python/qemu/qmp/legacy.py
> @@ -50,7 +50,7 @@
>
> # QMPMessage can be outgoing commands or incoming events/returns.
> # QMPReturnValue is usually a dict/json object, but due to QAPI's
> -# 'returns-whitelist', it can actually be anything.
> +# 'command-returns-exceptions', it can actually be anything.
> #
> # {'return': {}} is a QMPMessage,
> # {} is the QMPReturnValue.
> --
> 2.31.1
>
May I cajole you to send a MR to
https://gitlab.com/qemu-project/python-qemu-qmp ?
(Sorry for the duplicated effort while the library isn't 100% split
out of the tree yet.)
In this case, for qemu.git:
Reviewed-by: John Snow <jsnow@redhat.com>