Re: [PATCH] tests/vm: Update haiku test vm to R1/Beta3

[Thomas Huth]

On 16/02/2022 19.12, Alexander von Gluck IV wrote:
> February 16, 2022 10:26 AM, "Thomas Huth" <thuth@redhat.com> wrote:
> > On 16/02/2022 16.42, Alexander von Gluck IV wrote:
> >
> > > ---
> > > tests/vm/haiku.x86_64 | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > diff --git a/tests/vm/haiku.x86_64 b/tests/vm/haiku.x86_64
> > > index 2eb736dae1..936f7d2ae2 100755
> > > --- a/tests/vm/haiku.x86_64
> > > +++ b/tests/vm/haiku.x86_64
> > > @@ -2,7 +2,7 @@
> > > #
> > > # Haiku VM image
> > > #
> > > -# Copyright 2020 Haiku, Inc.
> > > +# Copyright 2020-2022 Haiku, Inc.
> > > #
> > > # Authors:
> > > # Alexander von Gluck IV <kallisti5@unixzen.com>
> > > @@ -48,8 +48,8 @@ class HaikuVM(basevm.BaseVM):
> > > name = "haiku"
> > > arch = "x86_64"
> > > > - link =
> > > "https://app.vagrantup.com/haiku-os/boxes/r1beta2-x86_64/versions/20200702/providers/libvirt.box";
> > > - csum = "41c38b316e0cbdbc66b5dbaf3612b866700a4f35807cb1eb266a5bf83e9e68d5"
> > > + link =
> > > "https://app.vagrantup.com/haiku-os/boxes/r1beta3-x86_64/versions/20220216/providers/libvirt.box";
> > > + csum = "e67d4aacbcc687013d5cc91990ddd86cc5d70a5d28432ae2691944f8ce5d5041"
> > > > poweroff = "shutdown"
> > > > @@ -99,7 +99,7 @@ class HaikuVM(basevm.BaseVM):
> > > > self.print_step("Extracting disk image")
> > > > - subprocess.check_call(["tar", "xzf", tarball, "./box.img", "-O"],
> > > + subprocess.check_call(["tar", "xzf", tarball, "box.img", "-O"],
> > > stdout=open(img, 'wb'))
> > > > self.print_step("Preparing disk image")
> >
> > Thank you very much for the quick fix, that indeed helps to compile-test Haiku 
> > again! (the unit
> > tests are failing, though, but IIRC that was already the case before)
> >
> > Tested-by: Thomas Huth <thuth@redhat.com>
>
> Thanks!
>
> Sorry for forgetting about it.   I hand release Vagrant images for Haiku after 
> major releases
> and generally forget to update them until ~6 months after a major release as 
> there aren't many users.
>
> I don't have commit access to qemu so will need someone else to push when the 
> time comes.

 Hi,

I think this could either go through the qemu-trivial tree, or I can pick it 
up and take it through my "testing" tree.

But I just noticed that your patch lacks the "Signed-off-by" line ... so for 
the records (it's required for the rules, see
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line 
)
could you either please reply with a "Signed-off-by" line to your original 
patch, or repost the whole patch as a v2 with the S-o-b included? Thanks!

 Thomas