Re: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set

qemu-trivial

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext

From:	Richard Henderson
Subject:	Re: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext
Date:	Tue, 2 Nov 2021 23:40:38 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/2/21 6:52 PM, Warner Losh wrote:

+    env->regs[15] = tswap32(gr[TARGET_REG_PC]);


This will be able to crash qemu with an odd pc in thumb mode.
You'd have to artificially create this mcontext of course.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 20/30] bsd-user/arm/target_arch_signal.h: arm machine context for signals, (continued)
- [PATCH v2 21/30] bsd-user/arm/target_arch_signal.h: arm user context and trapframe for signals, Warner Losh, 2021/11/02
  - Re: [PATCH v2 21/30] bsd-user/arm/target_arch_signal.h: arm user context and trapframe for signals, Richard Henderson, 2021/11/02
- [PATCH v2 23/30] bsd-user/arm/target_arch_signal.h: arm get_mcontext, Warner Losh, 2021/11/02
- [PATCH v2 26/30] bsd-user: add arm target build, Warner Losh, 2021/11/02
  - Re: [PATCH v2 26/30] bsd-user: add arm target build, Richard Henderson, 2021/11/02
    - Re: [PATCH v2 26/30] bsd-user: add arm target build, Warner Losh, 2021/11/03
- [PATCH v2 25/30] bsd-user/arm/target_arch_signal.h: arm get_ucontext_sigreturn, Warner Losh, 2021/11/02
  - Re: [PATCH v2 25/30] bsd-user/arm/target_arch_signal.h: arm get_ucontext_sigreturn, Richard Henderson, 2021/11/02
- [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext, Warner Losh, 2021/11/02
  - Re: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext, Richard Henderson <=
    - Re: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext, Warner Losh, 2021/11/03
- [PATCH v2 16/30] bsd-user/arm/target_arch_elf.h: arm get hwcap, Warner Losh, 2021/11/02
- [PATCH v2 27/30] bsd-user/i386/target_arch_signal.h: Remove target_sigcontext, Warner Losh, 2021/11/02
  - Re: [PATCH v2 27/30] bsd-user/i386/target_arch_signal.h: Remove target_sigcontext, Richard Henderson, 2021/11/02
- [PATCH v2 29/30] bsd-user/i386/target_arch_signal.h: use new target_os_ucontext.h, Warner Losh, 2021/11/02
  - Re: [PATCH v2 29/30] bsd-user/i386/target_arch_signal.h: use new target_os_ucontext.h, Richard Henderson, 2021/11/02
- [PATCH v2 30/30] bsd-user/x86_64/target_arch_signal.h: use new target_os_ucontext.h, Warner Losh, 2021/11/02
  - Re: [PATCH v2 30/30] bsd-user/x86_64/target_arch_signal.h: use new target_os_ucontext.h, Richard Henderson, 2021/11/02
- [PATCH v2 28/30] bsd-user/x86_64/target_arch_signal.h: Remove target_sigcontext, Warner Losh, 2021/11/02
  - Re: [PATCH v2 28/30] bsd-user/x86_64/target_arch_signal.h: Remove target_sigcontext, Richard Henderson, 2021/11/02

Prev by Date: Re: [PATCH v2 22/30] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args
Next by Date: Re: [PATCH v2 25/30] bsd-user/arm/target_arch_signal.h: arm get_ucontext_sigreturn
Previous by thread: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext
Next by thread: Re: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext
Index(es):
- Date
- Thread