|
From: | Richard Henderson |
Subject: | Re: [PATCH 04/24] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions |
Date: | Thu, 28 Oct 2021 08:14:23 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 10/19/21 9:44 AM, Warner Losh wrote:
+ cpsr_write(env, regs->uregs[16], 0xffffffff, CPSRWriteRaw);
This looks a bit suspicious. Over in linux-user we use cpsr_write(env, regs->uregs[16], CPSR_USER | CPSR_EXEC, CPSRWriteByInstr);Are you setting something special in pt_regs that would warrant writing supervisor bits of CPSR? In addition, CPSRWriteRaw won't rebuild hflags, which means that changes to Thumb state won't be recognized properly.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |