[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu/physmem.c: Fix typo in comment
From: |
David Hildenbrand |
Subject: |
Re: [PATCH] softmmu/physmem.c: Fix typo in comment |
Date: |
Fri, 15 Oct 2021 11:30:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 15.10.21 11:29, Greg Kurz wrote:
> Fix the comment to match what the code is doing, as explained in
> the changelog of commit 86cf9e154632cb28d749db0ea47946fba8cf3f09
> that introduced the change:
>
> Commit 9458a9a1df1a4c719e24512394d548c1fc7abd22 added synchronization
> of vCPU and migration operations through calling run_on_cpu operation.
> However, in replay mode this synchronization is unneeded, because
> I/O and vCPU threads are already synchronized.
> This patch disables such synchronization for record/replay mode.
>
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> softmmu/physmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/softmmu/physmem.c b/softmmu/physmem.c
> index f67ad2998121..555c907f6743 100644
> --- a/softmmu/physmem.c
> +++ b/softmmu/physmem.c
> @@ -2633,7 +2633,7 @@ static void tcg_log_global_after_sync(MemoryListener
> *listener)
> * In record/replay mode this causes a deadlock, because
> * run_on_cpu waits for rr mutex. Therefore no races are possible
> * in this case and no need for making run_on_cpu when
> - * record/replay is not enabled.
> + * record/replay is enabled.
> */
> cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener);
> run_on_cpu(cpuas->cpu, do_nothing, RUN_ON_CPU_NULL);
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb