[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] target/i386: Include 'hw/i386/apic.h' locally
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3] target/i386: Include 'hw/i386/apic.h' locally |
|
Date: |
Tue, 5 Oct 2021 21:27:18 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/5/21 18:45, Laurent Vivier wrote:
> Le 05/10/2021 à 16:57, Michael S. Tsirkin a écrit :
>> On Wed, Sep 29, 2021 at 06:31:24PM +0200, Philippe Mathieu-Daudé wrote:
>>> Instead of including a sysemu-specific header in "cpu.h"
>>> (which is shared with user-mode emulations), include it
>>> locally when required.
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>
>> which tree? trivial I guess?
>
> Yes, but for me the patch was not correct because there is no need to update
> target/i386/cpu-dump.c
> But perhaps I misunderstood the answer from Philippe?
You understood correctly, this series requires a respin.