[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host
From: |
Peter Maydell |
Subject: |
Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host |
Date: |
Mon, 27 Sep 2021 10:14:31 +0100 |
On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Reported-by: Warner Losh <imp@bsdimp.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> bsd-user/meson.build | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/bsd-user/meson.build b/bsd-user/meson.build
> index 03695493408..a7607e1c884 100644
> --- a/bsd-user/meson.build
> +++ b/bsd-user/meson.build
> @@ -1,3 +1,7 @@
> +if not config_host.has_key('CONFIG_BSD')
> + subdir_done()
> +endif
> +
> bsd_user_ss.add(files(
> 'bsdload.c',
> 'elfload.c',
So, what's the reason for this change? The commit messages and
the cover letter don't really explain it. Is this fixing a bug
(if so what?), a precaution to avoid possible future bugs,
fixing a performance issue with how long meson takes to run (if
so, how much effect does this have), or something else?
thanks
-- PMM
[PATCH 2/2] linux-user: Only process meson rules on Linux host, Philippe Mathieu-Daudé, 2021/09/26