Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

[WANG Xuerui]

On 9/27/21 10:42, WANG Xuerui wrote:

> On 9/27/21 06:01, Philippe Mathieu-Daudé wrote:
> > Reported-by: Warner Losh <imp@bsdimp.com>
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >   bsd-user/meson.build | 4 ++++
> >   1 file changed, 4 insertions(+)
>
> I'm newcomer here, but this is just 4 lines of Meson, and two similar 
> usages already exist within QEMU proper so...
>
> Reviewed-by: WANG Xuerui <git@xen0n.name>
Hmm, other replies pointed out that one can also make the top-level 
subdir() call conditional... And we seem to have more than 2 usages 
following the latter pattern instead. However putting the conditional in 
sub-directory makes the logic localized, which is arguably more friendly 
to someone casually browsing the source code.

As both ways work, I think maybe being consistent and moving things to 
top-level meson.build has more value?