[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/9] hw/virtio: Document *_should_notify() are called within rcu_r
From: |
Laurent Vivier |
Subject: |
[PULL 6/9] hw/virtio: Document *_should_notify() are called within rcu_read_lock() |
Date: |
Fri, 9 Jul 2021 22:28:21 +0200 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Such comments make reviewing this file somehow easier.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210523094040.3516968-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/virtio/virtio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 6dcf3baf56b7..874377f37a70 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2447,6 +2447,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value)
}
}
+/* Called within rcu_read_lock(). */
static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
{
uint16_t old, new;
@@ -2483,6 +2484,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool
wrap,
return vring_need_event(off, new, old);
}
+/* Called within rcu_read_lock(). */
static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
{
VRingPackedDescEvent e;
--
2.31.1
- [PULL 0/9] Trivial branch for 6.1 patches, Laurent Vivier, 2021/07/09
- [PULL 1/9] qemu-option: Drop dead assertion, Laurent Vivier, 2021/07/09
- [PULL 6/9] hw/virtio: Document *_should_notify() are called within rcu_read_lock(),
Laurent Vivier <=
- [PULL 2/9] memory: Display MemoryRegion name in read/write ops trace events, Laurent Vivier, 2021/07/09
- [PULL 8/9] migration: fix typo in mig_throttle_guest_down comment, Laurent Vivier, 2021/07/09
- [PULL 4/9] virtiofsd: Add missing newline in error message, Laurent Vivier, 2021/07/09
- [PULL 5/9] misc: Remove redundant new line in perror(), Laurent Vivier, 2021/07/09
- [PULL 9/9] util/guest-random: Fix size arg to tail memcpy, Laurent Vivier, 2021/07/09
- [PULL 7/9] target/xtensa/xtensa-semi: Fix compilation problem on Haiku, Laurent Vivier, 2021/07/09
- [PULL 3/9] misc: Fix "havn't" typo, Laurent Vivier, 2021/07/09
- Re: [PULL 0/9] Trivial branch for 6.1 patches, Peter Maydell, 2021/07/11