[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within r
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock() |
Date: |
Sat, 5 Jun 2021 21:06:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
Le 23/05/2021 à 11:40, Philippe Mathieu-Daudé a écrit :
> Such comments make reviewing this file somehow easier.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: only one space before end of comment (mst)
> ---
> hw/virtio/virtio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index e02544b2df7..130e3568409 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int
> value)
> }
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> uint16_t old, new;
> @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool
> wrap,
> return vring_need_event(off, new, old);
> }
>
> +/* Called within rcu_read_lock(). */
> static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq)
> {
> VRingPackedDescEvent e;
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
- Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock(),
Laurent Vivier <=