qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add display suboptions to man pages


From: Gerd Hoffmann
Subject: Re: [PATCH] Add display suboptions to man pages
Date: Tue, 1 Jun 2021 07:10:55 +0200

  Hi,

>  SRST
>  ``-numa 
> node[,mem=size][,cpus=firstcpu[-lastcpu]][,nodeid=node][,initiator=initiator]``
> -  \ 
> +  \

Seems some unrelated (whitespace?) changes sneaked in.

> @@ -1819,11 +1819,22 @@ SRST
>      old style -sdl/-curses/... options. Use ``-display help`` to list
>      the available display types. Valid values for type are
>  
> -    ``sdl``
> +    ``spice-app[,gl=on|off]``
> +        Start QEMU as a Spice server and launch the default Spice client
> +        application. The Spice server will redirect the serial consoles
> +        and QEMU monitors. (Since 4.0)
> +
> +    
> ``sdl[,alt_grab=on|off][,ctrl_grab=on|off][,window_close=on|off][,gl=on|core|es|off]``
> +
>          Display video output via SDL (usually in a separate graphics
>          window; see the SDL documentation for other possibilities).

alt-grab and ctrl-grab are deprecated and should not be added here.
please use dash not underscore (i.e. "window-close") here and elsewhere.

> +    ``vnc=<display>[,<optarges>]``
> +        Start a VNC server on display <arg>

No.  Works for compatibility reasons, but vnc has its own "-vnc" switch
which should be used instead.

> -ERST
> +    ERST

I think indenting this breaks the scripts processing the file ...

>  ``-mon [chardev=]name[,mode=readline|control][,pretty[=on|off]]``
> -    Setup monitor on chardev name. ``mode=control`` configures 
> +    Setup monitor on chardev name. ``mode=control`` configures

More unrelated changes ...

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]