[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] net: remove qemu_ether_ntoa()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] net: remove qemu_ether_ntoa() |
|
Date: |
Fri, 26 Feb 2021 13:52:06 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/26/21 1:06 PM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The function is not thread-safe and sets a bad example. It's used in a
> single place for tracing, so open-code the format string like other
> trace events with MAC addresses.
>
> Cc: qemu-trivial@nongnu.org
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/qemu-common.h | 1 -
> net/announce.c | 8 +++++++-
> util/cutils.c | 13 -------------
> net/trace-events | 2 +-
> 4 files changed, 8 insertions(+), 16 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>