[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/i386/xen: Remove dead code
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] hw/i386/xen: Remove dead code |
Date: |
Sat, 13 Feb 2021 23:37:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
Le 02/02/2021 à 16:56, Philippe Mathieu-Daudé a écrit :
> 'drivers_blacklisted' is never accessed, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/i386/xen/xen_platform.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
> index 7c4db35debb..01ae1fb1618 100644
> --- a/hw/i386/xen/xen_platform.c
> +++ b/hw/i386/xen/xen_platform.c
> @@ -60,7 +60,6 @@ struct PCIXenPlatformState {
> MemoryRegion bar;
> MemoryRegion mmio_bar;
> uint8_t flags; /* used only for version_id == 2 */
> - int drivers_blacklisted;
> uint16_t driver_product_version;
>
> /* Log from guest drivers */
> @@ -245,18 +244,10 @@ static void platform_fixed_ioport_writeb(void *opaque,
> uint32_t addr, uint32_t v
>
> static uint32_t platform_fixed_ioport_readw(void *opaque, uint32_t addr)
> {
> - PCIXenPlatformState *s = opaque;
> -
> switch (addr) {
> case 0:
> - if (s->drivers_blacklisted) {
> - /* The drivers will recognise this magic number and refuse
> - * to do anything. */
> - return 0xd249;
> - } else {
> - /* Magic value so that you can identify the interface. */
> - return 0x49d2;
> - }
> + /* Magic value so that you can identify the interface. */
> + return 0x49d2;
> default:
> return 0xffff;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent