[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/14] hw/display/pxa2xx_lcd: Replace printf() call by qemu_l
From: |
Alistair Francis |
Subject: |
Re: [PATCH 14/14] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask() |
Date: |
Tue, 26 May 2020 10:28:29 -0700 |
On Mon, May 25, 2020 at 11:36 PM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Replace printf() calls by qemu_log_mask(UNIMP), which is
> disabled by default. This avoid flooding the terminal when
> fuzzing the device.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/display/pxa2xx_lcd.c | 26 ++++++++++++++------------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c
> index d5f2e82a4e..ff90104b80 100644
> --- a/hw/display/pxa2xx_lcd.c
> +++ b/hw/display/pxa2xx_lcd.c
> @@ -426,9 +426,10 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr
> offset,
> if ((s->control[0] & LCCR0_ENB) && !(value & LCCR0_ENB))
> s->status[0] |= LCSR0_QD;
>
> - if (!(s->control[0] & LCCR0_LCDT) && (value & LCCR0_LCDT))
> - printf("%s: internal frame buffer unsupported\n", __func__);
> -
> + if (!(s->control[0] & LCCR0_LCDT) && (value & LCCR0_LCDT)) {
> + qemu_log_mask(LOG_UNIMP,
> + "%s: internal frame buffer unsupported\n",
> __func__);
> + }
> if ((s->control[3] & LCCR3_API) &&
> (value & LCCR0_ENB) && !(value & LCCR0_LCDT))
> s->status[0] |= LCSR0_ABC;
> @@ -462,9 +463,9 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr offset,
> break;
>
> case OVL1C1:
> - if (!(s->ovl1c[0] & OVLC1_EN) && (value & OVLC1_EN))
> - printf("%s: Overlay 1 not supported\n", __func__);
> -
> + if (!(s->ovl1c[0] & OVLC1_EN) && (value & OVLC1_EN)) {
> + qemu_log_mask(LOG_UNIMP, "%s: Overlay 1 not supported\n",
> __func__);
> + }
> s->ovl1c[0] = value & 0x80ffffff;
> s->dma_ch[1].up = (value & OVLC1_EN) || (s->control[0] & LCCR0_SDS);
> break;
> @@ -474,9 +475,9 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr offset,
> break;
>
> case OVL2C1:
> - if (!(s->ovl2c[0] & OVLC1_EN) && (value & OVLC1_EN))
> - printf("%s: Overlay 2 not supported\n", __func__);
> -
> + if (!(s->ovl2c[0] & OVLC1_EN) && (value & OVLC1_EN)) {
> + qemu_log_mask(LOG_UNIMP, "%s: Overlay 2 not supported\n",
> __func__);
> + }
> s->ovl2c[0] = value & 0x80ffffff;
> s->dma_ch[2].up = !!(value & OVLC1_EN);
> s->dma_ch[3].up = !!(value & OVLC1_EN);
> @@ -488,9 +489,10 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr
> offset,
> break;
>
> case CCR:
> - if (!(s->ccr & CCR_CEN) && (value & CCR_CEN))
> - printf("%s: Hardware cursor unimplemented\n", __func__);
> -
> + if (!(s->ccr & CCR_CEN) && (value & CCR_CEN)) {
> + qemu_log_mask(LOG_UNIMP,
> + "%s: Hardware cursor unimplemented\n", __func__);
> + }
> s->ccr = value & 0x81ffffe7;
> s->dma_ch[5].up = !!(value & CCR_CEN);
> break;
> --
> 2.21.3
>
>
- Re: [PATCH 10/14] hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR), (continued)
- [PATCH 12/14] hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR), Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 13/14] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP), Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 14/14] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask(), Philippe Mathieu-Daudé, 2020/05/26
- Re: [PATCH 14/14] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask(),
Alistair Francis <=
- Re: [PATCH 00/14] hw/display: Omnibus cleanups, Gerd Hoffmann, 2020/05/26
- Re: [PATCH 00/14] hw/display: Omnibus cleanups, no-reply, 2020/05/26