[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/14] hw/display/edid: Add missing 'qdev-properties.h' heade
From: |
Alistair Francis |
Subject: |
Re: [PATCH 01/14] hw/display/edid: Add missing 'qdev-properties.h' header |
Date: |
Tue, 26 May 2020 09:40:48 -0700 |
On Mon, May 25, 2020 at 11:23 PM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> When trying to consume the DEFINE_EDID_PROPERTIES() macro
> by including "hw/display/edid.h", we get this build failure:
>
> include/hw/display/edid.h:24:5: error: implicit declaration of
> function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
> 24 | DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \
> | ^~~~~~~~~~~~~~~~~~
>
> Headers should be self-contained, and one shouldn't have to
> dig to find the missing headers.
> In this case "hw/qdev-properties.h" is missing. Add it.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> include/hw/display/edid.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h
> index ff99dc0a05..23371ee82c 100644
> --- a/include/hw/display/edid.h
> +++ b/include/hw/display/edid.h
> @@ -2,6 +2,7 @@
> #define EDID_H
>
> #include "qom/object.h"
> +#include "hw/qdev-properties.h"
>
> typedef struct qemu_edid_info {
> const char *vendor; /* http://www.uefi.org/pnp_id_list */
> --
> 2.21.3
>
>
- [PATCH 00/14] hw/display: Omnibus cleanups, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 01/14] hw/display/edid: Add missing 'qdev-properties.h' header, Philippe Mathieu-Daudé, 2020/05/26
- Re: [PATCH 01/14] hw/display/edid: Add missing 'qdev-properties.h' header,
Alistair Francis <=
- [PATCH 02/14] hw/display/cg3: Convert debug printf()s to trace events, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 03/14] hw/display/cirrus_vga: Convert debug printf() to trace event, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 04/14] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 06/14] hw/display/cirrus_vga: Convert debug printf() to trace event, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 07/14] hw/display/dpcd: Fix memory region size, Philippe Mathieu-Daudé, 2020/05/26