[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/display/edid: Add missing 'qdev-properties.h' header
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/2] hw/display/edid: Add missing 'qdev-properties.h' header |
Date: |
Fri, 8 May 2020 20:55:29 +0200 |
On Mon, May 4, 2020 at 8:38 PM Richard Henderson
<address@hidden> wrote:
>
> On 5/4/20 1:20 AM, Philippe Mathieu-Daudé wrote:
> > To use the DEFINE_EDID_PROPERTIES() macro we need the
> > definitions from "hw/qdev-properties.h".
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > include/hw/display/edid.h | 1 +
> > 1 file changed, 1 insertion(+)
>
> Does this not currently build? I'm not sure what you're fixing.
Because when trying to use this header once included, I get when building:
include/hw/display/edid.h:24:5: error: implicit declaration of
function ‘DEFINE_PROP_UINT32’ [-Werror=implicit-function-declaration]
24 | DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \
| ^~~~~~~~~~~~~~~~~~
Then I've to grep for this macro and figure out I need to include
"hw/qdev-properties.h".
I am expecting a header providing a macro to also include the
pre-requisites, so I fixed in case someone else run into the same
problem.
Does it make sense? I can reword the patch description to better explain.
>
> r~
>