[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/9] block: Avoid dead assignment
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 1/9] block: Avoid dead assignment |
Date: |
Thu, 23 Apr 2020 20:11:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 22.04.20 15:31, Philippe Mathieu-Daudé wrote:
> Fix warning reported by Clang static code analyzer:
>
> block.c:3167:5: warning: Value stored to 'ret' is never read
> ret = bdrv_fill_options(&options, filename, &flags, &local_err);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 462f5bcf6
> Reported-by: Clang Static Analyzer
> Suggested-by: Markus Armbruster <address@hidden>
> Reviewed-by: Alistair Francis <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [PATCH v3 0/9] misc: Trivial static code analyzer fixes, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 2/9] blockdev: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 1/9] block: Avoid dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- Re: [PATCH v3 1/9] block: Avoid dead assignment,
Max Reitz <=
- [PATCH v3 4/9] hw/input/adb-kbd: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 3/9] hw/i2c/pm_smbus: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 5/9] hw/ide/sii3112: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 6/9] hw/isa/i82378: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 7/9] hw/gpio/aspeed_gpio: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 9/9] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning, Philippe Mathieu-Daudé, 2020/04/22
- [PATCH v3 8/9] hw/timer/stm32f2xx_timer: Remove dead assignment, Philippe Mathieu-Daudé, 2020/04/22