[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/3] display/blizzard: Remove redundant statement in blizz
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v4 2/3] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() |
Date: |
Tue, 24 Mar 2020 09:38:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
Le 24/03/2020 à 09:22, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read
> data >>= 5;
> ^ ~
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> Cc: Andrzej Zaborowski <address@hidden>
> Cc: Peter Maydell <address@hidden>
> ---
> hw/display/blizzard.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c
> index 359e399c2a..62517bdf75 100644
> --- a/hw/display/blizzard.c
> +++ b/hw/display/blizzard.c
> @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest,
> g = (data & 0x3f) << 2;
> data >>= 6;
> r = (data & 0x1f) << 3;
> - data >>= 5;
> *dest++ = rgb_to_pixel32(r, g, b);
> }
> }
>
Perhaps it would be clearer to use extract32() to compute r, g and b?
Thanks,
Laurent