[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64
From: |
Aleksandar Markovic |
Subject: |
Re: [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64 |
Date: |
Sat, 14 Mar 2020 04:06:21 +0100 |
On Fri, Mar 13, 2020 at 1:28 AM Lirong Yuan <address@hidden> wrote:
>
> This change updates TASK_UNMAPPED_BASE (the base address for guest programs)
> for aarch64. It is needed to allow qemu to work with Thread Sanitizer (TSan),
> which has specific boundary definitions for memory mappings on different
> platforms:
> https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/tsan/rtl/tsan_platform.h
>
> Signed-off-by: Lirong Yuan <address@hidden>
> ---
> linux-user/mmap.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 8685f02e7e..e378033797 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -184,7 +184,11 @@ static int mmap_frag(abi_ulong real_start,
> }
>
> #if HOST_LONG_BITS == 64 && TARGET_ABI_BITS == 64
> +#ifdef TARGET_AARCH64
> +# define TASK_UNMAPPED_BASE 0x5500000000
Hi, Lirong,
Can you point from which line of the file you linked to did you
arrive to the value 0x5500000000?
Second question: What about other targets?
Regards,
Aleksandar
> +#else
> # define TASK_UNMAPPED_BASE (1ul << 38)
> +#endif
> #else
> # define TASK_UNMAPPED_BASE 0x40000000
> #endif
> --
> 2.25.1.481.gfbce0eb801-goog
>
>