Re: [Qemu-trivial] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Thomas Huth]

On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
> Hi Paolo, Eduardo,
> 
> On 12/18/18 4:22 PM, Eduardo Habkost wrote:
>> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
>>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
>>>> Nobody is looking at those files, downgrade this subsystem as orphan.
>>>>
>>>> Remove the address@hidden entry because the list is always
>>>> selected by the 'All patches CC here' section.
>>>>
>>>> Suggested-by: Markus Armbruster <address@hidden>
>>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>>> ---
>>>>  MAINTAINERS | 3 +--
>>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index e50f8c6b97..e6a73820f1 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -1745,8 +1745,7 @@ S: Supported
>>>>  F: scripts/coverity-model.c
>>>>  
>>>>  CPU
>>>> -L: address@hidden
>>>> -S: Supported
>>>> +S: Orphan
>>>>  F: qom/cpu.c
>>>>  F: include/qom/cpu.h
>>>>  
>>>>
>>>
>>> I don't think that's accurate.  Simply there's not much going on.  If
>>> patches are sent, get-maintainers's git fallback will do something
>>> (probably sending the patch to Eduardo, Igor or me).
> 
> I followed Markus suggestion from
> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:
> 
>   If we take the definition of S: in MAINTAINERS seriously,
>   we need to appoint a maintainer (a person, not a mailing list),
>   or downgrade to S: Orphan.

I agree with Markus and Philippe. Having "S: Supported" but no names
available is just confusing. So either put a maintainer name in here, or
downgrade to "Orphan".

 Thomas