[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] misc, ide: remove use of HWADDR_
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] misc, ide: remove use of HWADDR_PRIx in trace events |
|
Date: |
Tue, 6 Mar 2018 14:24:40 +0000 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Mar 06, 2018 at 02:16:00PM +0000, Mark Cave-Ayland wrote:
> On 06/03/18 13:44, Daniel P. Berrangé wrote:
>
> > The trace events all use a uint64_t data type, so should be using the
> > corresponding PRIx64 format, not HWADDR_PRIx which is intended for use
> > with the 'hwaddr' type.
>
> Ha okay looks like you beat me to it ;) I wonder if we can teach
> checkpatch.pl about this...
We should just make tracetool whitelist the data types it permits, and
it could also report on unusual format macros like this - only allow
the standard PRI* ones. That way all build configs would immediately
fail, instead of only the ust build config
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|