[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 17/26] usb: ehci: fix memory leak in ehci_process_i
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 17/26] usb: ehci: fix memory leak in ehci_process_itd |
Date: |
Sat, 8 Oct 2016 11:58:03 +0300 |
From: Li Qiang <address@hidden>
While processing isochronous transfer descriptors(iTD), if the page
select(PG) field value is out of bands it will return. In this
situation the ehci's sg list is not freed thus leading to a memory
leak issue. This patch avoid this.
Signed-off-by: Li Qiang <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/usb/hcd-ehci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index b093db7..f4ece9a 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -1426,6 +1426,7 @@ static int ehci_process_itd(EHCIState *ehci,
if (off + len > 4096) {
/* transfer crosses page border */
if (pg == 6) {
+ qemu_sglist_destroy(&ehci->isgl);
return -1; /* avoid page pg + 1 */
}
ptr2 = (itd->bufptr[pg + 1] & ITD_BUFPTR_MASK);
--
2.1.4
- [Qemu-trivial] [PULL 00/26] Trivial patches for 2016-10-08, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 16/26] qapi: make the json schema files more regular., Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 10/26] MAINTAINERS: Add some more rocker related files, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 13/26] MAINTAINERS: Add some more MIPS related files, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 14/26] MAINTAINERS: Some updates related to the SH4 machines, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 17/26] usb: ehci: fix memory leak in ehci_process_itd,
Michael Tokarev <=
- [Qemu-trivial] [PULL 11/26] MAINTAINERS: Add some more pattern to recognize all win32 related files, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 03/26] tests: Ignore test executables, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 09/26] MAINTAINERS: Add header files to CRIS section, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 19/26] m68k: change default system clock for m5208evb, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 26/26] net/filter-mirror: Fix mirror initial check typo, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 21/26] bitmap: refine and move BITMAP_{FIRST/LAST}_WORD_MASK, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 22/26] CODING_STYLE: Fix a typo ("have" vs. "has"), Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 05/26] MAINTAINERS: Add some more files to the HMP section, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 07/26] MAINTAINERS: Add some SPARC machine related files, Michael Tokarev, 2016/10/08
- [Qemu-trivial] [PULL 23/26] char: fix missing return in error path for chardev TLS init, Michael Tokarev, 2016/10/08