[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PULL 01/10] hw/acpi/ich9: clear smi_en on reset
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-trivial] [PULL 01/10] hw/acpi/ich9: clear smi_en on reset |
Date: |
Mon, 27 Jul 2015 23:50:08 +0300 |
On Mon, Jul 27, 2015 at 10:54:04PM +0300, Michael Tokarev wrote:
> From: Laszlo Ersek <address@hidden>
>
> Otherwise on reboot firmware might think (due to APMC_EN remaining set
> from the previous boot) that SMI support is absent.
>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: address@hidden
> Signed-off-by: Laszlo Ersek <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>
Confused. Why are you merging these patches through your tree?
I was preparing a pull request myself, while likely git
will figure it out fine, this commit will appear twice in
history and it's kind of messy.
I guess I could drop this - but it's more work ...
> ---
> hw/acpi/ich9.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index f04f6dc..8da5a2d 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -221,6 +221,7 @@ static void pm_reset(void *opaque)
> acpi_pm_tmr_reset(&pm->acpi_regs);
> acpi_gpe_reset(&pm->acpi_regs);
>
> + pm->smi_en = 0;
> if (!pm->smm_enabled) {
> /* Mark SMM as already inited to prevent SMM from running. KVM does
> not
> * support SMM mode. */
> --
> 2.1.4
- [Qemu-trivial] [PULL 02/10] hw/acpi/ich9: clean up stale comment about KVM not supporting SMM, (continued)
- [Qemu-trivial] [PULL 02/10] hw/acpi/ich9: clean up stale comment about KVM not supporting SMM, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 06/10] vmstate: remove unused declaration, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 08/10] Fix Cortex-A9 global timer, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 07/10] gitignore: Ignore shader generated files, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 10/10] gdbstub: Set current CPU on interruptions, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 03/10] device_tree: Fix a typo, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 09/10] qapi: add missing @, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 04/10] qemu-common.h: Document cutils.c string functions, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 05/10] make: Clean build messages, Michael Tokarev, 2015/07/27
- [Qemu-trivial] [PULL 01/10] hw/acpi/ich9: clear smi_en on reset, Michael Tokarev, 2015/07/27
- Re: [Qemu-trivial] [PULL 01/10] hw/acpi/ich9: clear smi_en on reset,
Michael S. Tsirkin <=
- Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.4 00/10] Trivial patches for 2015-07-27, Peter Maydell, 2015/07/28