qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] memory_mapping: Use qemu_common.


From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] memory_mapping: Use qemu_common.h include
Date: Tue, 26 May 2015 19:18:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0


On 26/05/2015 19:05, Peter Crosthwaite wrote:
> OK, but it is an odd one out, would you be willing to accept
> the double include that seems to be widespread?
> 
> +#include "qemu_common.h"
>  #include "cpu.h"
> -#include "exec/cpu-all.h"

This is exactly what I meant.  What is odd about it?

In fact, including exec/cpu-all.h outside cpu.h is definitely odd.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]