qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] libcacard: stop including qem


From: Laurent Desnogues
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h
Date: Wed, 6 May 2015 14:01:04 +0200

On Wed, May 6, 2015 at 12:05 PM, Michael Tokarev <address@hidden> wrote:
> 06.05.2015 12:23, Laurent Desnogues wrote:
>> Hello,
>>
>> On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev <address@hidden> wrote:
>>> From: Paolo Bonzini <address@hidden>
>>>
>>> This is a small step towards making libcacard standalone.
>>
>> on my system the removal of qemu-common.h inclusion broke compilation
>> due to assert being used in glib-compat.h.
>
> Interesting. What kind of build environment is that?  I compile-tested on
> several platforms, all went fine.. ;)

That's a CentOS 6.6 machine with glib2 2.28.8.

>>     A  fix might be to include
>> assert.h in glib-compat.h.
>
> I prefer s/assert/g_assert/ in glib-compat.h.

That indeed looks better :-)

Thanks,

Laurent

> Thanks,
>
> /mjt
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]