[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 01/46] target-mips: Clean up switch fall through af
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 01/46] target-mips: Clean up switch fall through after commit fecd264 |
Date: |
Tue, 10 Feb 2015 09:33:50 +0300 |
From: Markus Armbruster <address@hidden>
Commit fecd264 added a number of fall-throughs, but neglected to
properly document them as intentional. Commit d922445 cleaned that up
for many, but not all cases. Take care of the remaining ones.
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
target-mips/translate.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index e9d86b2..1faeb5d 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -18729,6 +18729,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext
*ctx)
case OPC_SWL:
case OPC_SWR:
check_insn_opc_removed(ctx, ISA_MIPS32R6);
+ /* fall through */
case OPC_SB ... OPC_SH:
case OPC_SW:
gen_st(ctx, op, rt, rs, imm);
@@ -18817,6 +18818,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext
*ctx)
case OPC_PS_FMT:
check_cp1_enabled(ctx);
check_insn_opc_removed(ctx, ISA_MIPS32R6);
+ /* fall through */
case OPC_S_FMT:
case OPC_D_FMT:
check_cp1_enabled(ctx);
@@ -19000,6 +19002,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext
*ctx)
case OPC_LDL ... OPC_LDR:
case OPC_LLD:
check_insn_opc_removed(ctx, ISA_MIPS32R6);
+ /* fall through */
case OPC_LWU:
case OPC_LD:
check_insn(ctx, ISA_MIPS3);
@@ -19008,6 +19011,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext
*ctx)
break;
case OPC_SDL ... OPC_SDR:
check_insn_opc_removed(ctx, ISA_MIPS32R6);
+ /* fall through */
case OPC_SD:
check_insn(ctx, ISA_MIPS3);
check_mips_64(ctx);
--
2.1.4
- [Qemu-trivial] [PULL 00/46] Trivial patches for 2015-02-10, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 08/46] virtfs-proxy-helper: Fix possible socket leak., Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 04/46] Add trace to ps2.c., Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 12/46] linux-user/syscall.c: do_ioctl_dm: Need to call unlock_user() before going to failure return in default case, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 36/46] translate-all: Use g_try_malloc() for dynamic translator buffer, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 02/46] fw_cfg: fix typos in comments: patch -> path, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 34/46] rdma: g_malloc0() can't fail, bury dead error handling, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 37/46] disas/cris: Fix warning caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 41/46] moxie: Fix warning caused by missing include statement, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 06/46] Convert some debugging printfs to trace calls in pcnet.c., Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 01/46] target-mips: Clean up switch fall through after commit fecd264,
Michael Tokarev <=
- [Qemu-trivial] [PULL 07/46] vl: Fix bogus error message for implied mon ID clashing, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 38/46] disas/sh4: Fix warning caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 29/46] QJSON: fix typo in author's email address, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 42/46] serial: Fix warnings caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 26/46] util/uri: uri_new() can't fail, drop dead error handling, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 45/46] vga: Fix warning caused by missing 'static' attribute, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 11/46] linux-user/main.c: Use TARGET_SIG* instead of SIG*, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 25/46] usb: Pair g_malloc() with g_free(), not free(), Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 10/46] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base, Michael Tokarev, 2015/02/10
- [Qemu-trivial] [PULL 18/46] vl.c: fix memory leak spotted by valgrind, Michael Tokarev, 2015/02/10