[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] arch_init: Setting QEMU_ARCH enum straight
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH] arch_init: Setting QEMU_ARCH enum straight |
|
Date: |
Mon, 15 Sep 2014 17:03:40 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0 |
08.09.2014 16:30, Bastian Koppelmann wrote:
> Every QEMU_ARCH is now hexadecimal instead of a mixture of decimal and
> hexadecimal.
I'm not sure it is worth the trouble really. For readability, the best in this
case
(in my opinion anyway) is to use (1<<n) notation (with consecutive n), so it
becomes
really obvious that these are distinct bits. Besides, -0x01 (fo ARCH_ALL) does
look
a bit weird :)
Thanks,
/mjt