[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v6 04/10] ivshmem: check the value returned by
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-trivial] [PATCH v6 04/10] ivshmem: check the value returned by fstat() |
Date: |
Thu, 14 Aug 2014 12:12:50 +0200 |
On Thu, Aug 14, 2014 at 03:29:15PM +0800, zhanghailiang wrote:
> The function fstat() may fail, so check its return value.
>
> Acked-by: Levente Kurusa <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/misc/ivshmem.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 768e528..2be4b86 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -324,7 +324,11 @@ static int check_shm_size(IVShmemState *s, int fd) {
>
> struct stat buf;
>
> - fstat(fd, &buf);
> + if (fstat(fd, &buf) < 0) {
> + fprintf(stderr, "ivshmem: exiting: fstat on fd %d failed: %s\n",
> + fd, strerror(errno));
> + return -1;
> + }
>
> if (s->ivshmem_size > buf.st_size) {
> fprintf(stderr,
> --
> 1.7.12.4
>
- Re: [Qemu-trivial] [PATCH v6 00/10] fix three bugs about use-after-free and several api abuse, (continued)
- Re: [Qemu-trivial] [PATCH v6 00/10] fix three bugs about use-after-free and several api abuse, Michael S. Tsirkin, 2014/08/14
- Re: [Qemu-trivial] [PATCH v6 00/10] fix three bugs about use-after-free and several api abuse, Michael S. Tsirkin, 2014/08/14
- [Qemu-trivial] [PATCH v6 06/10] slirp/misc: Use g_malloc() instead of malloc(), zhanghailiang, 2014/08/14
- [Qemu-trivial] [PATCH v6 05/10] util/path: Use the GLib memory allocation routines, zhanghailiang, 2014/08/14
- [Qemu-trivial] [PATCH v6 04/10] ivshmem: check the value returned by fstat(), zhanghailiang, 2014/08/14
- [Qemu-trivial] [PATCH v6 07/10] linux-user: check return value of malloc(), zhanghailiang, 2014/08/14
- [Qemu-trivial] [PATCH v6 09/10] tcg: check return value of fopen(), zhanghailiang, 2014/08/14